Implemented methods login() and findByEmail() #1266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarakhmen
suggested changes
Oct 20, 2025
Contributor
sarakhmen
left a comment
sarakhmen
left a comment
There was a problem hiding this comment.
let's improve your solution :)
| */ | ||
| public boolean login(String email, String password) { | ||
| return false; | ||
| UserService userService = new UserService(); |
Contributor
There was a problem hiding this comment.
initialize this service in class fields
Comment on lines
18
to
22
| if (newUser != null) { | ||
| return newUser.getPassword().equals(password); | ||
| } else { | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
use ternary operator here
| public boolean login(String email, String password) { | ||
| return false; | ||
| UserService userService = new UserService(); | ||
| User newUser = userService.findByEmail(email); |
Contributor
There was a problem hiding this comment.
rename this variable to be clear and correct in terms of the context
sarakhmen
suggested changes
Oct 21, 2025
src/main/java/mate/academy/Main.java
Outdated
Comment on lines
8
to
31
| private static String str = new String("hello".toCharArray()); | ||
|
|
||
| public static void main(String[] args) { | ||
| test("[email protected]", "1234", true); | ||
| test("[email protected]", "1234", true); | ||
| test("[email protected]", "1234", false); | ||
| test("[email protected]", "qwerty", false); | ||
| } | ||
|
|
||
| private static void test(String email, String password, boolean expected) { | ||
| boolean actual = authenticationService.login(email, password); | ||
| if (expected == actual) { | ||
| System.out.println("Test passed for email: " + email + " and password " + password); | ||
| } else { | ||
| System.out.print("Expected to receive " + expected + ", but was " + actual + ". "); | ||
| System.out.println("Email: " + email + ", password " + password); | ||
| } | ||
| } | ||
|
|
||
| public static void smth(String s) { | ||
| String s21 = str.intern(); | ||
| System.out.println(); | ||
| } | ||
| } |
Elena-Bruyako
suggested changes
Oct 21, 2025
src/main/java/mate/academy/Main.java
Outdated
Comment on lines
8
to
9
| private static String str = new String("hello".toCharArray()); | ||
|
|
There was a problem hiding this comment.
remove
Suggested change
| private static String str = new String("hello".toCharArray()); |
Elena-Bruyako
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.